[PATCH] D138526: [SimpleLoopUnswitch] unswitch selects

Mon May 1 20:59:11 PDT 2023

vitalybuka added a comment.

In D138526#4311286 <https://reviews.llvm.org/D138526#4311286>, @caojoshua wrote:

> Its too hard to reproduce this locally on my personal machine. @vitalybuka I see you submitted a build for this patch <https://lab.llvm.org/buildbot/#/buildrequests/8577609>. Lets see how that goes.
>
> msan is reporting using unitialized end iterator <https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/ADT/IntervalTree.h#L688>. The end_iterator should be initialized with the default constructor <https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/ADT/IntervalTree.h#L544>, and I'm not sure yet how my change could break that.

Yes, it passed on the parent. Also I bisected locally and this is the patch.
Easy way to reproduce is https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild
We need to revert as it breaks existing feature. Unless there is a prove that C++ code is invalid (I can't see that).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138526/new/

https://reviews.llvm.org/D138526