[PATCH] D149586: [Coverity] Fix unchecked return value, NFC

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 19:23:56 PDT 2023


pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/EarlyIfConversion.cpp:348
+    assert(!TII->reverseBranchCondition(Condition) &&
+           "Reverse predicate is not supported");
   // Terminators don't need to be predicated as they will be removed.
----------------
barannikov88 wrote:
> This is wrong. Assert will be removed in release mode, along with the call.
> 
Good catch, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149586/new/

https://reviews.llvm.org/D149586



More information about the llvm-commits mailing list