[PATCH] D149294: Do not optimize debug locations across section boundaries

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2044
+         PrevInstBB->getSectionIDNum() == MI->getParent()->getSectionIDNum());
+
+  if (DL == PrevInstLoc && PrevInstInSameSection) {
----------------
Nit: It's more common to omit the blank line.


================
Comment at: llvm/test/DebugInfo/debuglineinfo-at-section-boundary.ll:1
+; RUN: llc -filetype=asm -asm-verbose=0 --basic-block-sections=all < %s | FileCheck %s
+;
----------------
Drop `-filetype=asm`. It's the default and assumed by most `llc invocations.

Drop `-asm-verbose=0` as well. There is no difference in the output. The option isn't common to specify.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149294/new/

https://reviews.llvm.org/D149294