[PATCH] D143897: [CodeGenPrepare] Estimate liveness of loop invariants when checking for address folding profitability

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 17:24:19 PDT 2023


rupprecht added a comment.

In D143897#4310910 <https://reviews.llvm.org/D143897#4310910>, @efriedma wrote:

> All the operations involved here should be deterministic.  You're probably looking for a bug elsewhere.  One possibility is that LoopInfo doesn't contain the correct information... for example, the CFG changes, but that change isn't recorded in LoopInfo.

Ack. To clarify, I'm fairly confident this patch _causes_ non-determinism, as I can bisect to this commit and reproduce it, and not at the commit prior to it, etc. But of course this might be doing a valid, deterministic transformation that triggers an existing non-determinism bug later on, or something like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143897/new/

https://reviews.llvm.org/D143897



More information about the llvm-commits mailing list