[PATCH] D149614: [Docs][TypeMetadata] Type metadata is generated for targets other than x86-64 so remove the stale comments.

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 17:01:32 PDT 2023


mingmingl added a comment.

In D149614#4310989 <https://reviews.llvm.org/D149614#4310989>, @pcc wrote:

> This is function type metadata, which uses a separate implementation to vtable type metadata that is platform-dependent. See `LowerTypeTestsModule::createJumpTableEntry` for the list of supported architectures.

thanks! Just to make sure my understanding is correct,

- LowerTypeTests.cpp makes use of function type metadata to emit jump tables, and the support for jump table is platform-dependent (which makes sense).
- Assuming that function type metadata is generated in Clang (at this place https://github.com/llvm/llvm-project/blob/7dc5635d71ea919c933a6dc7c204d7bcfb8711b8/clang/lib/CodeGen/CodeGenModule.cpp#L2177), the generation of function type metadata doesn't seem to be platform dependent.

The reason to update this part is that type metadata exist in non x86-64 IR, and used in places more than creating jump-table entries. So I thought the update would be useful for availability of the metadata (more than the platform-dependent use of it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149614/new/

https://reviews.llvm.org/D149614



More information about the llvm-commits mailing list