[PATCH] D149481: [TargetLowering] Don't use ISD::SELECT_CC in expandFP_TO_INT_SAT.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 1 15:28:33 PDT 2023
efriedma added a comment.
> Why is SELECT_CC a thing at all?
On targets where compare instructions modify a flag register, "SELECT" and "BRCOND" aren't really the natural representation; it effectively makes `x != 0` a special case. SELECT_CC and BR_CC represent the combination of a comparison followed by a branch.
That said, a lot of of targets with a flag register prefer to to custom-lower SETCC anyway, so maybe it's not as useful today.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149481/new/
https://reviews.llvm.org/D149481
More information about the llvm-commits
mailing list