[PATCH] D149614: [Docs][TypeMetadata] Type metadata is generated for targets other than x86-64 so remove the stale comments.

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 15:13:06 PDT 2023


mingmingl added a comment.

In D149614#4310751 <https://reviews.llvm.org/D149614#4310751>, @pcc wrote:

> This should probably be replaced with a list of supported architectures instead.

The code where vtable type metadata is annotated (https://github.com/llvm/llvm-project/blob/c9d14b23292979a9b3846cd55e2fc4d96b20f33f/clang/lib/CodeGen/CGVTables.cpp#L1328) doesn't seem to rely on target-specific information. May I get some input on where the x86_64 limitation is initially added (even if it's just an implementation artifact)?

A best-effort exhaustive test would tell the list of supported architectures currently but could become stale; so if there is no target-specific dependency, i wonder if 'the type metadata is generated on arch1, arch2.. and could be extended at <pointer> for other archs' (which I would need input with).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149614/new/

https://reviews.llvm.org/D149614



More information about the llvm-commits mailing list