[PATCH] D149577: [InstCombine] Improve bswap optimization

Austin Chang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 14:12:09 PDT 2023


austin880625 added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/bswap-fold.ll:542
 
+; Issue#62236
+; Fold: BSWAP( OP( BSWAP(x), y ) ) -> OP( x, BSWAP(y) )
----------------
goldstein.w.n wrote:
> Can you split the new tests to a seperate patch so we can see the diff generated?
> 
Just to confirm(newbie here), are the following separated patches you want:

1. first one in old implementation and new tests with FileCheck lines generated with old `opt`
2. second one with my actual code change, and the new tests with updated FileCheck lines generated with the changed opt. And the patch is based diff-ed with the first one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149577/new/

https://reviews.llvm.org/D149577



More information about the llvm-commits mailing list