[PATCH] D149173: [llvm][vfs] Avoid silent fallback to process-wide working directory

Jan Svoboda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 10:52:53 PDT 2023


jansvoboda11 accepted this revision.
jansvoboda11 added a comment.

This is a step in the right direction, so LGTM.

But I think it would be nicer to fail earlier (in the constructor), or propagate the error out of `adjustPath()`. What do you think? Would be nice to add a FIXME for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149173/new/

https://reviews.llvm.org/D149173



More information about the llvm-commits mailing list