[PATCH] D146349: [InstCombine] Make `FoldOpIntoSelect` handle non-constants and use condition to deduce constants.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D146349#4309379 <https://reviews.llvm.org/D146349#4309379>, @nikic wrote:

> Sorry, I missed something in this patch as well. This transform isn't valid for undef constants: https://alive2.llvm.org/ce/z/4JjGKv We should guard it against isGuaranteedNotToBeUndefOrPoison.

Because its constant elements can we just do `C->containsUndefOrPoisonElement()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146349/new/

https://reviews.llvm.org/D146349