[PATCH] D147588: [LV] Add a test for register pressure estimation. NFC

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/interleave-count.ll:8
+
+define void @test(ptr %dst, i64 %len) {
+; CHECK-LABEL: LV: Checking a loop in 'test'
----------------
please add a comment indicating what this is testing. Might also e good to have. amore descriptive test file name,


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/interleave-count.ll:26
+entry:
+  %size = shl i64 %len, 3
+  %p.end = getelementptr inbounds double, ptr %dst, i64 %size
----------------
is this needed?


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/interleave-count.ll:35
+  %done = icmp eq ptr %p.next, %p.end
+  br i1 %done, label %exit, label %loop, !prof !{!"branch_weights", i32 1, i32 1000000}
+
----------------
Is the branch weight needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147588/new/

https://reviews.llvm.org/D147588