[PATCH] D149566: [CodeGen] Replace CCState's getNextStackOffset with getStackSize (NFC)

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 created this revision.
Herald added subscribers: luke, kosarev, foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, fedor.sergeev, kbarton, hiraditya, arichardson, jvesely, nemanjai, sdardis, dylanmckay, jyknight, arsenm.
Herald added a project: All.
barannikov88 edited the summary of this revision.
barannikov88 updated this revision to Diff 518383.
barannikov88 added a comment.
barannikov88 updated this revision to Diff 518413.
barannikov88 updated this revision to Diff 518417.
barannikov88 updated this revision to Diff 518418.
barannikov88 published this revision for review.
barannikov88 added reviewers: arsenm, yusra.syeda, efriedma.
Herald added subscribers: llvm-commits, pcwang-thead, MaskRay, wdng.
Herald added a project: LLVM.

Self-review fixes


barannikov88 added a comment.

Small fix


barannikov88 added a comment.

clang-format


barannikov88 added a comment.

Disregard clang-format broken suggestions


The term "next stack offset" is misleading because the next argument is
not necessarily allocated at this offset due to alignment constrains.
It also does not make much sense when allocating arguments at negative
offsets (introduced in a follow-up patch), because the returned offset
would be past the end of the next argument.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149566

Files:
  llvm/include/llvm/CodeGen/CallingConvLower.h
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/lib/CodeGen/CallingConvLower.cpp
  llvm/lib/Target/AArch64/AArch64FastISel.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/ARC/ARCISelLowering.cpp
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/ARM/ARMCallingConv.cpp
  llvm/lib/Target/ARM/ARMFastISel.cpp
  llvm/lib/Target/ARM/ARMISelLowering.cpp
  llvm/lib/Target/AVR/AVRISelLowering.cpp
  llvm/lib/Target/BPF/BPFISelLowering.cpp
  llvm/lib/Target/CSKY/CSKYISelLowering.cpp
  llvm/lib/Target/Hexagon/HexagonISelLowering.cpp
  llvm/lib/Target/Lanai/LanaiISelLowering.cpp
  llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
  llvm/lib/Target/M68k/GISel/M68kCallLowering.cpp
  llvm/lib/Target/M68k/M68kISelLowering.cpp
  llvm/lib/Target/MSP430/MSP430ISelLowering.cpp
  llvm/lib/Target/Mips/MipsCallLowering.cpp
  llvm/lib/Target/Mips/MipsFastISel.cpp
  llvm/lib/Target/Mips/MipsISelLowering.cpp
  llvm/lib/Target/PowerPC/PPCFastISel.cpp
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/lib/Target/Sparc/SparcISelLowering.cpp
  llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
  llvm/lib/Target/VE/VEISelLowering.cpp
  llvm/lib/Target/X86/X86CallLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/XCore/XCoreISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149566.518418.patch
Type: text/x-patch
Size: 47982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230501/ddc23cf4/attachment.bin>