[PATCH] D149576: [bazel] Fix layering check after 0610e2f
Christian Sigg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 1 03:05:55 PDT 2023
csigg created this revision.
Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, sanjoy.google, thopre.
Herald added a project: All.
csigg requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added a project: LLVM.
`BytecodeWriter.h` is now included in `IR.h`, and the corresponding dependency should be moved to `header_deps`. This change fixes Google's internal build, which seems to have a stricter layering check than bazel's, but it's still the right thing to do.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D149576
Files:
utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
Index: utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -372,6 +372,7 @@
"include/mlir/CAPI/Wrap.h",
],
header_deps = [
+ ":BytecodeWriter",
":IR",
":Pass",
":Support",
@@ -380,7 +381,6 @@
includes = ["include"],
deps = [
":AsmParser",
- ":BytecodeWriter",
":ConversionPassIncGen",
":FuncDialect",
":InferTypeOpInterface",
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149576.518415.patch
Type: text/x-patch
Size: 609 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230501/a8d389a0/attachment.bin>
More information about the llvm-commits
mailing list