[PATCH] D149533: Regen some old tests; NFC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 02:48:15 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/sub-cmp-peephole.ll:4
 ; RUN: llc < %s -mtriple=arm-apple-darwin | FileCheck %s --check-prefix=V7
 ; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s -check-prefix=V8
 
----------------
These need cleaning up - duplicate RUN, and I think you can have a common CHECK prefix as well
```
; RUN: llc < %s -mtriple=arm-apple-darwin | FileCheck %s --check-prefixes=CHECK,V7
; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s --check-prefixes=CHECK,V8
```


================
Comment at: llvm/test/CodeGen/ARM/sub-cmp-peephole.ll:87
 ; CHECK: rsbeq
 ; CHECK: cmp
 define i32 @bc_raise(i1 %cond) nounwind ssp {
----------------
remove these


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149533/new/

https://reviews.llvm.org/D149533



More information about the llvm-commits mailing list