[PATCH] D148906: [AMDGPU] Remove function if FeatureWavefrontSize 32/64 is not supported on current GPU

[krishna chaitanya sankisa via Phabricator via llvm-commits]

skc7 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURemoveIncompatibleFunctions.cpp:146
   for (unsigned Feature : FeaturesToCheck) {
     if (ST->hasFeature(Feature) && !GPUFeatureBits.test(Feature)) {
       OptimizationRemarkEmitter ORE(&F);
----------------
@arsenm  AFAIU, This condition checks that (for ex.) if wave32 mode is enabled and current GPU doesn't support waveforntsize32 feature, then that function should be deleted. 
This inherently fulfills the condition "//delete wave32 functions for <gfx10 targets that don't support the mode//" ?  Please let me know if I'm missing anything here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148906/new/

https://reviews.llvm.org/D148906