[PATCH] D146350: [InstCombine] More aggressively try and fold irem/idiv/mul into selects.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/binop-select.ll:548
   ret i32 %div
 }
----------------
goldstein.w.n wrote:
> nikic wrote:
> > Also test the straightforward case where the mul has a constant operand? Or is that already handled somewhere else (and if so, can we remove it)?
> hmm? Not sure what you mean by this comment.
I mean something like `(c ? x : C1) * C2`, that isn't based on the select condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146350/new/

https://reviews.llvm.org/D146350