[PATCH] D146350: [InstCombine] More aggressively try and fold irem/idiv/mul into selects.

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 30 22:01:12 PDT 2023


goldstein.w.n marked 4 inline comments as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/binop-select.ll:548
   ret i32 %div
 }
----------------
nikic wrote:
> Also test the straightforward case where the mul has a constant operand? Or is that already handled somewhere else (and if so, can we remove it)?
hmm? Not sure what you mean by this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146350/new/

https://reviews.llvm.org/D146350



More information about the llvm-commits mailing list