[PATCH] D149510: [ValueTracking] add UGT/UGE and lshr case in imply icmp

Sun Apr 30 07:28:49 PDT 2023

goldstein.w.n added a comment.

In D149510#4308323 <https://reviews.llvm.org/D149510#4308323>, @floatshadow wrote:

> In D149510#4307842 <https://reviews.llvm.org/D149510#4307842>, @goldstein.w.n wrote:
>
>> LGTM. I'm not a maintainer to please wait a day or so to push so other have a chance to see.
>
> Thanks. I am not surely why `isImpliedCondOperands` handles less case only. Do we expect instcombine will canonicalize this?

I'm not really sure. I think probably alot of the patterns are scattered around instcombine + instsimplify but
probably also alot of holes that just havent been filled in yet and could use patches.

Maybe @nikic knows.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149510/new/

https://reviews.llvm.org/D149510