[PATCH] D149528: [TargetLowering] Stop passing an ISD::CondCode to isOperationLegalOrCustom.

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 29 13:55:54 PDT 2023


barannikov88 accepted this revision.
barannikov88 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6706
   // follows.
-  if (!isOperationLegalOrCustom(ISD::SETEQ, VT) ||
+  if (!isOperationLegalOrCustom(ISD::SETCC, VT) ||
       !isOperationLegalOrCustom(ISD::AND, VT) ||
----------------
Should this check `SETCCVT` instead? `SETEQ` is created below with this type.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149528/new/

https://reviews.llvm.org/D149528



More information about the llvm-commits mailing list