[PATCH] D149525: [JITLink][RISCV] Only generate PLT entries for external symbols

[Job Noorman via Phabricator via llvm-commits]

jobnoorman created this revision.
jobnoorman added reviewers: lhames, StephenFan, jrtc27.
Herald added subscribers: asb, luke, pmatos, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
jobnoorman requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

R_RISCV_CALL has been deprecated. [1] Both GCC and LLVM seem to not
generate it anymore and always use R_RISCV_CALL_PLT (even for calls that
do not need a PLT entry). Generating PLT entries based on relocation
type is not recommended and a better heuristic is to only generate them
when the target symbol is preemptable [2]. This patch implements this by
only generating PLT entries for external symbols.

[1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/340
[2] https://github.com/riscv-non-isa/riscv-elf-psabi-doc/issues/98

Depends on D149524 <https://reviews.llvm.org/D149524>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149525

Files:
  llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp
  llvm/test/ExecutionEngine/JITLink/RISCV/ELF_pc_indirect.s


Index: llvm/test/ExecutionEngine/JITLink/RISCV/ELF_pc_indirect.s
===================================================================
--- llvm/test/ExecutionEngine/JITLink/RISCV/ELF_pc_indirect.s
+++ llvm/test/ExecutionEngine/JITLink/RISCV/ELF_pc_indirect.s
@@ -5,11 +5,11 @@
 # RUN:     -o %t/elf_riscv32_sm_pic_reloc.o %s
 # RUN: llvm-jitlink -noexec \
 # RUN:     -slab-allocate 100Kb -slab-address 0x1ff00000 -slab-page-size 4096 \
-# RUN:     -abs external_func=0x1 -abs external_data=0x2 \
+# RUN:     -abs external_data=0x2 \
 # RUN:     -check %s %t/elf_riscv64_sm_pic_reloc.o
 # RUN: llvm-jitlink -noexec \
 # RUN:     -slab-allocate 100Kb -slab-address 0x1ff00000 -slab-page-size 4096 \
-# RUN:     -abs external_func=0x1 -abs external_data=0x2 \
+# RUN:     -abs external_data=0x2 \
 # RUN:     -check %s %t/elf_riscv32_sm_pic_reloc.o
 #
 # Test ELF small/PIC relocations
@@ -51,14 +51,34 @@
         .size   test_pcrel32_s, .-test_pcrel32_s
 
 # Test R_RISCV_CALL
-# jitlink-check: decode_operand(test_call, 1) = ((external_func - test_call) + 0x800)[31:12]
-# jitlink-check: decode_operand(test_call+4, 2)[11:0] = (external_func - test_call)[11:0]
-        .globl test_call, external_func
+# jitlink-check: decode_operand(test_call, 1) = ((internal_func - test_call) + 0x800)[31:12]
+# jitlink-check: decode_operand(test_call+4, 2)[11:0] = (internal_func - test_call)[11:0]
+        .globl test_call
         .p2align  1
         .type  test_call, at function
 test_call:
-        .reloc ., R_RISCV_CALL, external_func
+        .reloc ., R_RISCV_CALL, internal_func
         auipc ra, 0
         jalr ra
         ret
         .size test_call, .-test_call
+
+# Test R_RISCV_CALL_PLT
+# jitlink-check: decode_operand(test_call_plt, 1) = ((internal_func - test_call_plt) + 0x800)[31:12]
+# jitlink-check: decode_operand(test_call_plt+4, 2)[11:0] = (internal_func - test_call_plt)[11:0]
+        .globl test_call_plt
+        .p2align  1
+        .type  test_call_plt, at function
+test_call_plt:
+        .reloc ., R_RISCV_CALL_PLT, internal_func
+        auipc ra, 0
+        jalr ra
+        ret
+        .size test_call_plt, .-test_call_plt
+
+       .globl   internal_func
+       .p2align  1
+       .type    internal_func, at function
+internal_func:
+       ret
+       .size internal_func, .-internal_func
Index: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp
===================================================================
--- llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp
+++ llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp
@@ -76,7 +76,8 @@
   }
 
   bool isExternalBranchEdge(Edge &E) const {
-    return E.getKind() == R_RISCV_CALL_PLT;
+    return (E.getKind() == R_RISCV_CALL || E.getKind() == R_RISCV_CALL_PLT) &&
+           E.hasTarget() && E.getTarget().isExternal();
   }
 
 private:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149525.518222.patch
Type: text/x-patch
Size: 2808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230429/5b9a43f3/attachment.bin>