[PATCH] D149409: [ValueTracking] Handle bitcasts between vec-int-ptr in `isKnownNonZero`

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 29 11:57:47 PDT 2023


goldstein.w.n marked an inline comment as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2776
       return isKnownNonZero(I->getOperand(0), Depth, Q);
-    break;
+  } break;
   case Instruction::IntToPtr:
----------------
nikic wrote:
> I believe we can `return false` here now.
Think it makes sense to let `computeKnownBits` run. More future proof and could help in some cases (i.e the <4xi3> -> <3xi4> is provable in some cases (lsb + msb set in all `i3` elements) and computeKnownBits could (although granted doesn't at the moment) get that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149409/new/

https://reviews.llvm.org/D149409



More information about the llvm-commits mailing list