[PATCH] D149048: [AMDGPU][Disassembler] Pre-commit a test on an error message generated in an instruction comment.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 29 06:26:41 PDT 2023
arsenm added a comment.
In D149048#4298585 <https://reviews.llvm.org/D149048#4298585>, @kosarev wrote:
>> Test name could be more descriptive. Current name makes it sound like it's checking for any comments
>
> Well, it does. We don't want any comments for this instruction.
Yes, for *this* instruction. The general name sounds like it's for testing that comments are emitted in general
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149048/new/
https://reviews.llvm.org/D149048
More information about the llvm-commits
mailing list