[PATCH] D148046: [Symbolizer] Map from module-relative addresses in ProcessContext.

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr accepted this revision.
mcgrathr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp:121
                    MMap.Addr, MMap.Addr + MMap.Size - 1);
-    reportLocation(Node.Fields[0].begin());
+    reportLocation(Node.Text.begin());
     return true;
----------------
Is it not desirable to report the column location of the address field? This error is indicating that the address and/or size is problematic, so calling one of them the precise error location rather than the beginning of the line seems to make sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148046/new/

https://reviews.llvm.org/D148046