[PATCH] D149445: [MachineInst] Switch NumOperands to 16bits
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 28 17:00:26 PDT 2023
craig.topper added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:519
/// Retuns the total number of operands.
- unsigned getNumOperands() const { return NumOperands; }
+ uint16_t getNumOperands() const { return NumOperands; }
----------------
You can leave this returning unsigned
================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:626
/// Returns the number of non-implicit operands.
- unsigned getNumExplicitOperands() const;
+ uint16_t getNumExplicitOperands() const;
----------------
Leave this returning unsigned
================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:937
MachineInstr &New,
- unsigned MaxOperand) {
+ uint16_t MaxOperand) {
// If the Old instruction wasn't tracked at all, there is no work to do.
----------------
Leave this as unsigned.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149445/new/
https://reviews.llvm.org/D149445
More information about the llvm-commits
mailing list