[PATCH] D149400: [llvm-profdata] Deprecate Compact Binary Sample Profile Format

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:93
   SPF_Text = 0x1,
-  SPF_Compact_Binary = 0x2,
+/// (Deprecated)  SPF_Compact_Binary = 0x2,
   SPF_GCC = 0x3,
----------------
Keep the symbolic value with deprecation comment.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:56
   PF_Text,
-  PF_Compact_Binary,
   PF_Ext_Binary,
   PF_GCC,
----------------
The enum should be kept and synced with the definition in SampleProf.h.  Just add a deprecation comment.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:411
                   const StringRef ProfiledBinary) {
-  if (OutputFormat != PF_Binary && OutputFormat != PF_Compact_Binary &&
+  if (OutputFormat != PF_Binary &&
       OutputFormat != PF_Ext_Binary && OutputFormat != PF_Text)
----------------
For PF_Compact_Binary format, produce a different error message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149400/new/

https://reviews.llvm.org/D149400