[PATCH] D149421: [KnownBits] Improve `KnownBits::rem(X, Y)` in cases where we can deduce low-bits of output

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 12:22:35 PDT 2023


goldstein.w.n added a comment.

In D149421#4306030 <https://reviews.llvm.org/D149421#4306030>, @tschuett wrote:

> How about:
>
>   KnownBits remGetLowBits(const KnownBits &Known, const KnownBits &LHS,
>                             const KnownBits &RHS);
>
> Passing with `&`for mutability is always an odd pattern.

Agreed and done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149421/new/

https://reviews.llvm.org/D149421



More information about the llvm-commits mailing list