[PATCH] D149471: [InstCombine] Add A - B + B << 1 --> A + B

Ryan Taylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 10:48:57 PDT 2023


rtaylor created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
rtaylor requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Add instcombine transform A - B + B << 1 --> A + B


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149471

Files:
  llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
  llvm/test/Transforms/InstCombine/add.ll


Index: llvm/test/Transforms/InstCombine/add.ll
===================================================================
--- llvm/test/Transforms/InstCombine/add.ll
+++ llvm/test/Transforms/InstCombine/add.ll
@@ -2943,4 +2943,14 @@
   ret <2 x i32> %c
 }
 
+define i32 @add_shl_sub(i32 %a, i32 %b) {
+; CHECK-LABEL: @add_shl_sub
+; CHECK-NEXT: %add = add i32 %a, %b
+; CHECK-NEXT: ret i32 %add
+  %sub = sub i32 %a, %b
+  %mul = shl nsw i32 %b, 1
+  %add = add nsw i32 %sub, %mul
+  ret i32 %add
+}
+
 declare void @llvm.assume(i1)
Index: llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
===================================================================
--- llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
+++ llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
@@ -1390,6 +1390,13 @@
   }
 
   Value *A, *B;
+
+  // A - B + B << 1 -> A + B
+  if (match(LHS, m_Sub(m_Value(A), m_Value(B))) &&
+      match(RHS, m_Shl(m_Value(B), m_One())) &&
+      LHS->hasOneUse() && RHS->hasOneUse())
+    return BinaryOperator::CreateAdd(A, B);
+
   if (match(LHS, m_Neg(m_Value(A)))) {
     // -A + -B --> -(A + B)
     if (match(RHS, m_Neg(m_Value(B))))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149471.517992.patch
Type: text/x-patch
Size: 1152 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230428/daed48c5/attachment.bin>


More information about the llvm-commits mailing list