[PATCH] D149446: [Pipelines] Don't skip GlobalDCE in ThinLTO pre-link

Fri Apr 28 10:33:54 PDT 2023

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

In D149446#4305330 <https://reviews.llvm.org/D149446#4305330>, @tejohnson wrote:

> I was looking to see if I could determine why we wanted to keep unreferenced available_externally by looking at the history of this comment. It turns out this was only very recently moved into the module simplification pipeline in D145967 <https://reviews.llvm.org/D145967>. @aeubanks do you remember if there was a specific motivating case for the comment?

Hmm I swear I copied that comment from somewhere. That patch didn't actually change the pipeline, so maybe I incorrectly justified the state of things then. Anyway, lgtm

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149446/new/

https://reviews.llvm.org/D149446