[PATCH] D149421: [KnownBits] Improve `KnownBits::rem(X, Y)` in cases where we can deduce low-bits of output

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Support/KnownBits.cpp:565-567
   KnownBits Known(BitWidth);
 
+  remGetLowBits(Known, LHS, RHS);
----------------
foad wrote:
> New suggestion: simplify this to `KnownBits Known = remGetLowBits(LHS, RHS);`
Any objections to pass `Known` to `remGetLowBits` as const-ref? Don't want to force the assumption that `remGetLowBits` is called before any other bits are set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149421/new/

https://reviews.llvm.org/D149421