[PATCH] D149465: [NFC][SLP] Cleanup: Replace Value* operand with Instruction* in `vectorizeRootInstruction()` and `vectorizeHorReduction()`

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 10:11:48 PDT 2023


ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG with a nit



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:14549
+        Instruction *Root = getReductionInstr(DT, P, BB, LI);
+        if (Root != nullptr && vectorizeRootInstruction(P, Root, BB, R, TTI)) {
           Changed = true;
----------------
Just `if (Root &&...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149465/new/

https://reviews.llvm.org/D149465



More information about the llvm-commits mailing list