[PATCH] D42600: [CodeGen][Shrink-wrap]split restore point

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 09:22:49 PDT 2023


nickdesaulniers added a comment.

In D42600#4304778 <https://reviews.llvm.org/D42600#4304778>, @sushgokh wrote:

> @nathanchance Thanks for the update :)
>
> @nickdesaulniers Requesting approval for relanding

Can you please push the updated patch to this phab review (click reopen in the bottom left "Add Action..." menu) or a new one? It's hard for me to look at the diff without the surrounding context, which phab would allow me to view.

In particular, I'm concerned if the checks for `isInlineAsmBrIndirectTarget` in `ShrinkWrap::performShrinkWrapping` are still relevant after this change?

I would also like to see a `callbr` based test added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42600/new/

https://reviews.llvm.org/D42600



More information about the llvm-commits mailing list