[llvm] fae9d4d - [AIX][llvm-ar] Use the Correct Kind for Bitcode File Inputs

[Qiongsi Wu via llvm-commits]

Author: Qiongsi Wu
Date: 2023-04-28T09:14:10-04:00
New Revision: fae9d4df8fcff802dc7b0c344c61c70cc2a20697

URL: https://github.com/llvm/llvm-project/commit/fae9d4df8fcff802dc7b0c344c61c70cc2a20697
DIFF: https://github.com/llvm/llvm-project/commit/fae9d4df8fcff802dc7b0c344c61c70cc2a20697.diff

LOG: [AIX][llvm-ar] Use the Correct Kind for Bitcode File Inputs

On AIX, when the input files are LLVM bitcode files, `llvm-ar` should set the archive kind to `K_AIXBIG` as well, instead of leaving it to the default `K_GNU`.

Reviewed By: daltenty

Differential Revision: https://reviews.llvm.org/D149377

Added: 
    llvm/test/tools/llvm-ar/Inputs/aix-foo.ll
    llvm/test/tools/llvm-ar/aix-bitcode.test

Modified: 
    llvm/lib/Object/ArchiveWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Object/ArchiveWriter.cpp b/llvm/lib/Object/ArchiveWriter.cpp
index e9b88115195f4..1a540e261b2af 100644
--- a/llvm/lib/Object/ArchiveWriter.cpp
+++ b/llvm/lib/Object/ArchiveWriter.cpp
@@ -76,9 +76,11 @@ object::Archive::Kind NewArchiveMember::detectKindFromObject() const {
     if (auto ObjOrErr = object::SymbolicFile::createSymbolicFile(
             MemBufferRef, file_magic::bitcode, &Context)) {
       auto &IRObject = cast<object::IRObjectFile>(**ObjOrErr);
-      return Triple(IRObject.getTargetTriple()).isOSDarwin()
+      auto TargetTriple = Triple(IRObject.getTargetTriple());
+      return TargetTriple.isOSDarwin()
                  ? object::Archive::K_DARWIN
-                 : object::Archive::K_GNU;
+                 : (TargetTriple.isOSAIX() ? object::Archive::K_AIXBIG
+                                           : object::Archive::K_GNU);
     } else {
       // Squelch the error in case this was not a SymbolicFile.
       consumeError(ObjOrErr.takeError());

diff  --git a/llvm/test/tools/llvm-ar/Inputs/aix-foo.ll b/llvm/test/tools/llvm-ar/Inputs/aix-foo.ll
new file mode 100644
index 0000000000000..a22652ddd108e
--- /dev/null
+++ b/llvm/test/tools/llvm-ar/Inputs/aix-foo.ll
@@ -0,0 +1,8 @@
+target datalayout = "E-m:a-Fi64-i64:64-n32:64-S128-v256:256:256-v512:512:512"
+target triple = "powerpc64-ibm-aix7.2.0.0"
+
+define signext i32 @foo() {
+entry:
+  ret i32 42
+}
+

diff  --git a/llvm/test/tools/llvm-ar/aix-bitcode.test b/llvm/test/tools/llvm-ar/aix-bitcode.test
new file mode 100644
index 0000000000000..d3ce6f1b7343a
--- /dev/null
+++ b/llvm/test/tools/llvm-ar/aix-bitcode.test
@@ -0,0 +1,7 @@
+# Check if llvm-ar correctly archives bitcode files for AIX.
+# RUN: rm -rf %t && mkdir -p %t
+# RUN: llvm-as %S/Inputs/aix-foo.ll -o %t/aix-foo.bc
+# RUN: llvm-ar qc %t/aix-foo.a %t/aix-foo.bc
+# RUN: FileCheck %s --input-file=%t/aix-foo.a
+
+# CHECK:  bigaf