[PATCH] D149270: [LLD][MachO] Do not run Mach-O tests on big-endian hosts
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 28 05:51:54 PDT 2023
uweigand marked an inline comment as done.
uweigand added inline comments.
================
Comment at: lld/test/MachO/lit.local.cfg:8-9
+# on little-endian host systems. Skip all tests on big-endian hosts.
+if 's390x' in config.host_triple:
+ config.unsupported = True
+
----------------
oontvoo wrote:
> How about using the existing `host-byteorder-little-endian`/`host-byteorder-big-endian`?
>
> either adding this:
>
> ```
> REQUIRES: host-byteorder-little-endian
> ```
>
> or just checking `"host-byteorder-little-endian" in config.available_features` ?
Turns out those features are only available in the llvm test suite, not the lld test suite right now. I guess they could be added there, but for now I'm just directly checking `sys.byteorder` to identify big-endian hosts.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149270/new/
https://reviews.llvm.org/D149270
More information about the llvm-commits
mailing list