[PATCH] D149132: [LICM] Reassociate & hoist add expressions

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/LICM/hoist-add-sub.ll:394
 
-; TODO: iv + x < 4 ==> iv < 4 - x
+; iv + x < 4 ==> iv < 4 - x
 define i32 @test_04(ptr %p, ptr %x_p, ptr %length_p) {
----------------
TODO incorrectly dropped here. But I think maybe the test isn't right and `%x` is supposed to use range `!1` not `!0`? Same for the pair of tests above.


================
Comment at: llvm/test/Transforms/LICM/hoist-add-sub.ll:444
 
 ; TODO: iv + x < 4 ==> iv < 4 - x
 define i32 @test_04a(ptr %p, ptr %x_p, ptr %length_p) {
----------------
Drop TODO.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149132/new/

https://reviews.llvm.org/D149132