[PATCH] D149251: [SCEV] Don't expect BackedgeTakenCounts cache to contain an entry for loop in getBackedgeTakenInfo

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 04:39:19 PDT 2023


mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:8406
 #if LLVM_ENABLE_STATS || !defined(NDEBUG)
   const SCEV *BEExact = Result.getExact(L, this);
   if (BEExact != getCouldNotCompute()) {
----------------
If the recursion only exists in this debug code to count statistics, and not used in normal algorithm execution, why do we need it at all? I'd rather throw this away than add extra checks/updates just because a non-recursive algorithm becomes recursive because of stat computation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149251/new/

https://reviews.llvm.org/D149251



More information about the llvm-commits mailing list