[PATCH] D149373: [TEST][LICM] Add test cases on widenable condition hoisting opportunity

[Aleksandr Popov via Phabricator via llvm-commits]

aleksandr.popov added inline comments.


================
Comment at: llvm/test/Transforms/LICM/explicit_guards.ll:130
+; TODO: Hoist widenable condition out of loop since it's the only
+; non-invariant operand of its user
+define void @hoist_widenable_cond(ptr %p, i32 %x) {
----------------
skatkov wrote:
> I would add a description of opportunity.
> If we hoist WC we could hoist and as well otherwise it prevents us from doing that.
> I would add a description of opportunity.
Thanks, added


================
Comment at: llvm/test/Transforms/LICM/explicit_guards.ll:154
+; CHECK:       exit:
+; CHECK-NEXT:    ret void
+;
----------------
mkazantsev wrote:
> Please add a test where wc goes before the `icmp7` (see my comment to D149374).
Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149373/new/

https://reviews.llvm.org/D149373