[PATCH] D148963: [X86] Support `X86ISD::PCMPEQ` and `X86ISD::PCMPGT` in ComputeKnownBits

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Shouldn't this be a DAGCombine instead? It seems pointless to make computeKnownBits() recurse past an instruction that can only return either unknown or constant. If it returns constant, we want to just replace the instruction, and otherwise we get zero information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148963/new/

https://reviews.llvm.org/D148963