[compiler-rt] ab1094f - [NFC][HWASAN] Remove unnecessary untag

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 00:41:12 PDT 2023


Author: Vitaly Buka
Date: 2023-04-28T00:40:52-07:00
New Revision: ab1094f0daffb54851aa4597c2216e82fbad37d4

URL: https://github.com/llvm/llvm-project/commit/ab1094f0daffb54851aa4597c2216e82fbad37d4
DIFF: https://github.com/llvm/llvm-project/commit/ab1094f0daffb54851aa4597c2216e82fbad37d4.diff

LOG: [NFC][HWASAN] Remove unnecessary untag

Looks like HWASAN_ALIASING_MODE work around.
But any tagged pointer should be mapped, so load
should work.

Added: 
    

Modified: 
    compiler-rt/lib/hwasan/hwasan_checks.h

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/hwasan/hwasan_checks.h b/compiler-rt/lib/hwasan/hwasan_checks.h
index 6e2ab1693b53..616199aeb633 100644
--- a/compiler-rt/lib/hwasan/hwasan_checks.h
+++ b/compiler-rt/lib/hwasan/hwasan_checks.h
@@ -134,9 +134,6 @@ PossiblyShortTagMatches(tag_t mem_tag, uptr ptr, uptr sz) {
     return false;
   if ((ptr & (kShadowAlignment - 1)) + sz > mem_tag)
     return false;
-#if !defined(__aarch64__) && !(SANITIZER_RISCV64)
-  ptr = UntagAddr(ptr);
-#endif
   return *(u8 *)(ptr | (kShadowAlignment - 1)) == ptr_tag;
 }
 


        


More information about the llvm-commits mailing list