[compiler-rt] 81d0626 - [hwasan] Fix -Wunneeded-internal-declaration by declaring static inline

[Thurston Dang via llvm-commits]

Author: Thurston Dang
Date: 2023-04-28T03:34:44Z
New Revision: 81d06268f47f089335076eb608c880fc0e60a677

URL: https://github.com/llvm/llvm-project/commit/81d06268f47f089335076eb608c880fc0e60a677
DIFF: https://github.com/llvm/llvm-project/commit/81d06268f47f089335076eb608c880fc0e60a677.diff

LOG: [hwasan] Fix -Wunneeded-internal-declaration by declaring static inline

https://reviews.llvm.org/D149386 caused a buildbot error (https://lab.llvm.org/buildbot#builders/37/builds/21766):

'In file included from /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/hwasan/hwasan_interceptors.cpp:18:
/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/hwasan/hwasan_checks.h:128:53: error: 'static' function 'PossiblyShortTagMatches' declared in header file should be declared 'static inline' [-Werror,-Wunneeded-internal-declaration]
__attribute__((always_inline, nodebug)) static bool PossiblyShortTagMatches('

This patch simply adds the inline annotation.

Differential Revision: https://reviews.llvm.org/D149402

Added: 
    

Modified: 
    compiler-rt/lib/hwasan/hwasan_checks.h

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/hwasan/hwasan_checks.h b/compiler-rt/lib/hwasan/hwasan_checks.h
index 514d351cf7d72..6e2ab1693b531 100644
--- a/compiler-rt/lib/hwasan/hwasan_checks.h
+++ b/compiler-rt/lib/hwasan/hwasan_checks.h
@@ -125,8 +125,8 @@ __attribute__((always_inline)) static void SigTrap(uptr p, uptr size) {
   // __builtin_unreachable();
 }
 
-__attribute__((always_inline, nodebug)) static bool PossiblyShortTagMatches(
-    tag_t mem_tag, uptr ptr, uptr sz) {
+__attribute__((always_inline, nodebug)) static inline bool
+PossiblyShortTagMatches(tag_t mem_tag, uptr ptr, uptr sz) {
   tag_t ptr_tag = GetTagFromPointer(ptr);
   if (ptr_tag == mem_tag)
     return true;