[PATCH] D149396: [NFC] Add a test case to make sure EarlyCSE preserves !prof when `DoesKMmove` is false.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 18:03:58 PDT 2023


tejohnson added a comment.

Can you expand the summary to explain why it is being dropped, and conceptually what the fix is doing? I'm not familiar with DoesKMove and what the 2 cases are here.



================
Comment at: llvm/test/Transforms/EarlyCSE/metadata.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt < %s -S -passes=early-cse | FileCheck %s
----------------
Add a comment at the top about what this test is testing.


================
Comment at: llvm/test/Transforms/EarlyCSE/metadata.ll:21
+  %0 = load ptr, ptr %vfn, align 8
+  %call1 = tail call i32 %0(ptr %call, i32 %a, i32 %b), !prof !0
+  store i32 %call1, ptr %x
----------------
What was being CSE'd here that caused it to get dropped?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149396/new/

https://reviews.llvm.org/D149396



More information about the llvm-commits mailing list