[PATCH] D149124: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring - 3

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:689
+  /// to determine a cutoff.
+  bool useOrderedFuncOffsets() {
+    return ProfileIsCS || (!useMD5() && Remapper);
----------------
huangjd wrote:
> davidxl wrote:
> > does it need to check the section flag?
> I added back the section flag to check if CS profile has ordered function offset table.  
Does the function offset table for a remapper profile always come in sorted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149124/new/

https://reviews.llvm.org/D149124