[PATCH] D143369: [llvm-profdata] Fix bug llvm-profdata crashes when reading a text sample profile with an empty line with spaces.

Thu Apr 27 16:44:37 PDT 2023

huangjd added a comment.
Herald added a subscriber: wlei.

In D143369#4296705 <https://reviews.llvm.org/D143369#4296705>, @ro wrote:

> In D143369#4296667 <https://reviews.llvm.org/D143369#4296667>, @huangjd wrote:
>
>> 
>
>
>
>> What system are you running this on? I ran it on x86-64 linux and couldn't replicate it. It doesn't look like the line with `4.2` is skipped due to this patch, but instead it's parsed but being merged with the line with `4`, which indicates a bug somewhere else.
>
> This is Solaris/sparcv9 (`sparcv9-sun-solaris2.11`) and can also be seen on the corresponding buildbot <https://lab.llvm.org/staging/#/builders/50>.  I'm currently running both a debug build to be able to investigate more and a Linux/sparc64 build to see if the issue occurs there, too.  Unfortunately, those `Debug` builds are dog slow...
>
> I've also reverted your patch on `main` locally: all the failures seen in the buildbot vanish then.

Any leads on why it is crashing with debug build?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143369/new/

https://reviews.llvm.org/D143369