[PATCH] D149005: [VPlan] Turn Plan entry node into VPBasicBlock (NFCI).

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Looks good to me, with minor nits.
Worth explaining that Entry is the preheader of the vector loop.



================
Comment at: llvm/unittests/Transforms/Vectorize/VPDomTreeTest.cpp:40
 
+  VPBasicBlock *VPBB0 = new VPBasicBlock("VPBB0");
+  VPBlockUtils::connectBlocks(VPBB0, VPBB0);
----------------
nit: better placed in order, before VPBB1?


================
Comment at: llvm/unittests/Transforms/Vectorize/VPDomTreeTest.cpp:41
+  VPBasicBlock *VPBB0 = new VPBasicBlock("VPBB0");
+  VPBlockUtils::connectBlocks(VPBB0, VPBB0);
   VPlan Plan;
----------------
?


================
Comment at: llvm/unittests/Transforms/Vectorize/VPDomTreeTest.cpp:113
 
+    VPBasicBlock *VPBB0 = new VPBasicBlock("VPBB0");
+    VPBlockUtils::connectBlocks(VPBB0, R1);
----------------
nit: better place VPBB0 in order, before R1BB1?


================
Comment at: llvm/unittests/Transforms/Vectorize/VPDomTreeTest.cpp:114
+    VPBasicBlock *VPBB0 = new VPBasicBlock("VPBB0");
+    VPBlockUtils::connectBlocks(VPBB0, R1);
     VPlan Plan;
----------------
nit: better place right after creating `R1`?


================
Comment at: llvm/unittests/Transforms/Vectorize/VPlanTest.cpp:441
+    VPBasicBlock *VPBB0 = new VPBasicBlock("VPBB0");
+    VPBlockUtils::connectBlocks(VPBB0, R1);
+    Plan.setEntry(VPBB0);
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149005/new/

https://reviews.llvm.org/D149005