[PATCH] D144306: [BOLT] adding hash computation for basic blocks

[Sergey Pupyrev via Phabricator via llvm-commits]

spupyrev updated this revision to Diff 517703.
spupyrev added a comment.
Herald added a subscriber: pengfei.

Addressing comments:

- block's hash is optional in yaml
- using MIB->getShortBranchOpcode

I agree that not relying on specific opcodes is a good idea. Maybe that could be a follow-up diff?

Regarding LLVM's Hashing.h, I dropped one method from the diff, as it is already implemented. Anything else you have in mind regarding the helpers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144306/new/

https://reviews.llvm.org/D144306

Files:
  bolt/include/bolt/Core/BinaryBasicBlock.h
  bolt/include/bolt/Core/BinaryFunction.h
  bolt/include/bolt/Core/HashUtilities.h
  bolt/include/bolt/Core/MCPlusBuilder.h
  bolt/include/bolt/Profile/ProfileYAMLMapping.h
  bolt/lib/Core/BinaryFunction.cpp
  bolt/lib/Core/CMakeLists.txt
  bolt/lib/Core/HashUtilities.cpp
  bolt/lib/Passes/IdenticalCodeFolding.cpp
  bolt/lib/Profile/YAMLProfileWriter.cpp
  bolt/lib/Target/X86/X86MCPlusBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144306.517703.patch
Type: text/x-patch
Size: 16423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230427/9108d88c/attachment.bin>