[PATCH] D141188: [MergeICmps] Adapt to non-eq comparisons

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 13:13:49 PDT 2023


nikic added a comment.

In D141188#4303188 <https://reviews.llvm.org/D141188#4303188>, @aeubanks wrote:

> (unrelated, but is there any reason this pass is in the codegen pipeline instead of the optimization pipeline?)

The last attempt to move MergeICmps and ExpandMemCmp into the optimization pipeline ran into some issue (iirc related to sanitizers) and nobody looked into this in detail since. We would generally prefer to have them in the optimization pipeline, as the current backend position is too late to make full use of subsequent optimizations that may be enabled by them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141188/new/

https://reviews.llvm.org/D141188



More information about the llvm-commits mailing list