[llvm] 1176d97 - [memprof][NFC] Update a stale comment about symbolization.

Snehasish Kumar via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 11:59:38 PDT 2023


Author: Snehasish Kumar
Date: 2023-04-27T18:59:33Z
New Revision: 1176d97598a9b46573213d2d75e0c6d90226ada0

URL: https://github.com/llvm/llvm-project/commit/1176d97598a9b46573213d2d75e0c6d90226ada0
DIFF: https://github.com/llvm/llvm-project/commit/1176d97598a9b46573213d2d75e0c6d90226ada0.diff

LOG: [memprof][NFC] Update a stale comment about symbolization.

Symbolization of position independent code was added in D146181. Update
the comment to note that the checks below are to sanity check the
assumptions we make to simplify symbolization.

Differential Revision: https://reviews.llvm.org/D149370

Added: 
    

Modified: 
    llvm/lib/ProfileData/RawMemProfReader.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ProfileData/RawMemProfReader.cpp b/llvm/lib/ProfileData/RawMemProfReader.cpp
index 7c519ed492e45..dbfb472f211ed 100644
--- a/llvm/lib/ProfileData/RawMemProfReader.cpp
+++ b/llvm/lib/ProfileData/RawMemProfReader.cpp
@@ -282,8 +282,8 @@ Error RawMemProfReader::initialize(std::unique_ptr<MemoryBuffer> DataBuffer) {
   }
 
   // Check whether the profiled binary was built with position independent code
-  // (PIC). For now we provide a error message until symbolization support
-  // is added for pic.
+  // (PIC). Perform sanity checks for assumptions we rely on to simplify
+  // symbolization.
   auto* Elf64LEObject = llvm::cast<llvm::object::ELF64LEObjectFile>(ElfObject);
   const llvm::object::ELF64LEFile& ElfFile = Elf64LEObject->getELFFile();
   auto PHdrsOr = ElfFile.program_headers();


        


More information about the llvm-commits mailing list