[PATCH] D149370: [memprof][NFC] Update a stale comment about symbolization.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
snehasish requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Symbolization of position independent code was added in D146181 <https://reviews.llvm.org/D146181>. Update
the comment to note that the checks below are to sanity check the
assumptions we make to simplify symbolization.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149370

Files:
  llvm/lib/ProfileData/RawMemProfReader.cpp


Index: llvm/lib/ProfileData/RawMemProfReader.cpp
===================================================================
--- llvm/lib/ProfileData/RawMemProfReader.cpp
+++ llvm/lib/ProfileData/RawMemProfReader.cpp
@@ -282,8 +282,8 @@
   }
 
   // Check whether the profiled binary was built with position independent code
-  // (PIC). For now we provide a error message until symbolization support
-  // is added for pic.
+  // (PIC). Perform sanity checks for assumptions we rely on to simplify
+  // symbolization.
   auto* Elf64LEObject = llvm::cast<llvm::object::ELF64LEObjectFile>(ElfObject);
   const llvm::object::ELF64LEFile& ElfFile = Elf64LEObject->getELFFile();
   auto PHdrsOr = ElfFile.program_headers();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149370.517668.patch
Type: text/x-patch
Size: 713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230427/56500dd7/attachment-0001.bin>