[PATCH] D149298: [nfc][thinlto] Handle global constant importing separately

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:305
+  ~GlobalsImporter() {
+    while (!Worklist.empty())
+      onImportingSummary(*Worklist.pop_back_val());
----------------
tejohnson wrote:
> Some comments as to why we are doing this in the destructor would be helpful. But would it be clearer to just do this greedily from onImportingSummary? In fact, in that case we wouldn't even need a Worklist - onImportingSummary can just call itself recursively.
Done, w/o recursion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149298/new/

https://reviews.llvm.org/D149298