[PATCH] D148417: [compiler-rt][profiling] Add an incremental buffer writing mode to libprofile
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 27 09:56:17 PDT 2023
aemerson added inline comments.
================
Comment at: compiler-rt/lib/profile/InstrProfilingBuffer.c:191
+/// \returns whether or not \p Vec is padding or actual profiling data.
+static char isPadding(ProfDataIOVec Vec) {
+ return Vec.UseZeroPadding;
----------------
I think this can just take a pointer to ProfDataIOVec? It's a small struct but seems unnecessary to copy since the call site is already dealing with a ptr.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148417/new/
https://reviews.llvm.org/D148417
More information about the llvm-commits
mailing list