[PATCH] D149348: RFD: Do not CSE convergent calls in different basic blocks

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D149348#4302188 <https://reviews.llvm.org/D149348#4302188>, @foad wrote:

> Move logic from Instruction::hasSameSpecialState to
> Instruction::isIdenticalToWhenDefined. @nikic is that more acceptable?

Not really. All of those functions are about purely structural comparison of instructions, they don't reason about effects. Moving the check to EarlyCSE would be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149348/new/

https://reviews.llvm.org/D149348